-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-261: Role Service #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atye
requested review from
medegw01,
gallacher,
tdawe,
alikdell,
hoppea2,
coulof,
shaynafinocchiaro and
sharmilarama
as code owners
April 27, 2022 18:10
3 tasks
alikdell
approved these changes
May 4, 2022
shaynafinocchiaro
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a role service which will contain the logic for
karavictl role
commands in a helm deployment and implements thekaravictl role create
functionality.Here is a view of new files and service structure.
internal/types
holds types that are shared across services.internal/k8s
is an abstraction for working with configured storage and roles in k8s for any service can use.internal/role-service/service.go
is the role service that implements the role-service protobuf definitions.internal/role-service/roles
is existing code and provides management of role data.internal/role-service/validate
validates new roles for the storage types.See dell/helm-charts#109 for installing the helm chart and examples.
The
internal/k8s
package has low coverage because fake k8s client used for testing doesn't support the operation we are doing. kubernetes/client-go#970GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit tests and integration style testing via manually running karavictl.
? karavi-authorization/pb [no test files]