Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added changes for uploading the compliance file #112

Merged
merged 9 commits into from
May 9, 2024
Merged

added changes for uploading the compliance file #112

merged 9 commits into from
May 9, 2024

Conversation

AnikaAgiwal2711
Copy link
Collaborator

@AnikaAgiwal2711 AnikaAgiwal2711 commented May 8, 2024 •
edited by adarsh-dell
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1283

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

I've written Integration tests to test my changes

@AnikaAgiwal2711
Copy link
Collaborator Author

image

@AnikaAgiwal2711
Copy link
Collaborator Author

image

AkshaySainiDell
AkshaySainiDell approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

adarsh-dell
adarsh-dell reviewed May 9, 2024
View reviewed changes
upgrade.go Outdated Show resolved Hide resolved
@adarsh-dell
Copy link
Contributor

@AnikaAgiwal2711 , Is there any github issue associated with this PR?
How about adding copyright info all newly created files?
// Copyright © 2024 Dell Inc. or its subsidiaries. All Rights Reserved.

Thanks

@AnikaAgiwal2711
Copy link
Collaborator Author

@AnikaAgiwal2711 , Is there any github issue associated with this PR? How about adding copyright info all newly created files? // Copyright © 2024 Dell Inc. or its subsidiaries. All Rights Reserved.

Thanks

I've a JIRA ticket. Not a github issue

@AnikaAgiwal2711
Copy link
Collaborator Author

Github issue : dell/csm#1283

@AnikaAgiwal2711
Copy link
Collaborator Author

Done with all the changes

adarsh-dell
adarsh-dell approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AnikaAgiwal2711

@AnikaAgiwal2711 AnikaAgiwal2711 merged commit 6fc2fbf into main May 9, 2024
4 checks passed
@shanmydell shanmydell deleted the upload-compliance branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy ashleyvjoy is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell rishabhatdell is a code owner

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1 sakshi-garg1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnikaAgiwal2711 @adarsh-dell @AkshaySainiDell @Krunal-Thakkar