Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetStoragePoolVolumes api to get all volumes connected to given s… #111

Merged
merged 3 commits into from
May 14, 2024

Conversation

alikdell
Copy link
Contributor

@alikdell alikdell commented Apr 26, 2024

Description

Add GetStoragePoolVolumes api to get all volumes connected to given storagepool

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • # go test -v -run TestGetStoragePoolVolumes
    === RUN TestGetStoragePoolVolumes
    --- PASS: TestGetStoragePoolVolumes (0.26s)
    PASS
    ok github.com/dell/goscaleio/inttests 0.346s

  • Run manual test to get list of volumes belong to storagepool. Also used in CSM Authorization

@alikdell alikdell merged commit 91f179d into main May 14, 2024
4 checks passed
@alikdell alikdell deleted the storagepool-volumes branch May 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants