Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][OMEVV][omevv_firmware_repository_profile] - Added automation for delete operation. #745

Merged
merged 7 commits into from
Oct 22, 2024
Merged

[Integration][OMEVV][omevv_firmware_repository_profile] - Added automation for delete operation. #745

merged 7 commits into from
Oct 22, 2024

Conversation

singh-lovepreet1
Copy link
Collaborator

@singh-lovepreet1 singh-lovepreet1 commented Oct 14, 2024 •
edited
Loading

Description

Covering below test cases:
TC-157349
TC-157350
TC-157351

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@singh-lovepreet1 singh-lovepreet1 added the validation/in-progress Validation is in progress label Oct 14, 2024
@singh-lovepreet1 singh-lovepreet1 added this to the v9.8.0 milestone Oct 14, 2024
@singh-lovepreet1 singh-lovepreet1 self-assigned this Oct 14, 2024
@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@singh-lovepreet1 singh-lovepreet1 changed the title [Integration][OMEVV][omevv_firmware_repository_profile] - Added automation for delete operation [Integration][OMEVV][omevv_firmware_repository_profile] - Added automation for delete operation. TC-157349 TC-157350 TC-157351 Oct 16, 2024
@singh-lovepreet1
Added invalid scenarios
fca49f7 
Signed-off-by: Lovepreet Singh <[email protected]>
@singh-lovepreet1 singh-lovepreet1 changed the title [Integration][OMEVV][omevv_firmware_repository_profile] - Added automation for delete operation. TC-157349 TC-157350 TC-157351 [Integration][OMEVV][omevv_firmware_repository_profile] - Added automation for delete operation. Oct 17, 2024
sachin-apa
sachin-apa previously approved these changes Oct 21, 2024
View reviewed changes
@singh-lovepreet1
Updated messages
74638ae 
Signed-off-by: Lovepreet Singh <[email protected]>
@singh-lovepreet1 singh-lovepreet1 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Oct 21, 2024
@sachin-apa sachin-apa merged commit 0b02b60 into dell:collections Oct 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-apa sachin-apa sachin-apa approved these changes

@ShivamSh3 ShivamSh3 ShivamSh3 approved these changes

@Saksham-Nautiyal Saksham-Nautiyal Saksham-Nautiyal approved these changes

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 Awaiting requested review from ABHISHEK-SINHA10 ABHISHEK-SINHA10 is a code owner

@rajshekarp87 rajshekarp87 Awaiting requested review from rajshekarp87 rajshekarp87 is a code owner

Assignees

@singh-lovepreet1 singh-lovepreet1

Labels
validation/completed Validation is completed
Projects
None yet
Milestone
v9.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@singh-lovepreet1 @ansible-collections-svc @sachin-apa @ShivamSh3 @Saksham-Nautiyal