Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[omevv_firmware_repository_profile]: Create, modify and delete firmware repository profile #744

Merged
merged 13 commits into from
Oct 22, 2024
Merged

[omevv_firmware_repository_profile]: Create, modify and delete firmware repository profile #744

merged 13 commits into from
Oct 22, 2024

Conversation

ShivamSh3
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@ShivamSh3 ShivamSh3 changed the title [omevv_firmware_repository_profile]: Create and Modify [omevv_firmware_repository_profile]: Create, modify and delete firmware repository profile Oct 9, 2024
@ShivamSh3 ShivamSh3 added the validation/in-progress Validation is in progress label Oct 9, 2024
@ShivamSh3 ShivamSh3 added this to the v9.8.0 milestone Oct 9, 2024
reetivel
reetivel reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@reetivel reetivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
ABHISHEK-SINHA10
ABHISHEK-SINHA10 previously approved these changes Oct 15, 2024
View reviewed changes
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
@singh-lovepreet1 singh-lovepreet1 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Oct 21, 2024
reetivel
reetivel reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@reetivel reetivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review comments added

docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
docs/modules/omevv_firmware_repository_profile.rst Outdated Show resolved Hide resolved
sachin-apa
sachin-apa previously approved these changes Oct 21, 2024
View reviewed changes
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/modules/omevv_firmware_repository_profile.py Outdated Show resolved Hide resolved
plugins/module_utils/omevv_firmware_utils.py Outdated Show resolved Hide resolved
plugins/module_utils/omevv_firmware_utils.py Outdated Show resolved Hide resolved
@rajshekarp87 rajshekarp87 merged commit fc107be into dell:collections Oct 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajshekarp87 rajshekarp87 rajshekarp87 approved these changes

@sachin-apa sachin-apa sachin-apa approved these changes

@Saksham-Nautiyal Saksham-Nautiyal Awaiting requested review from Saksham-Nautiyal

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 Awaiting requested review from ABHISHEK-SINHA10 ABHISHEK-SINHA10 is a code owner

@reetivel reetivel Awaiting requested review from reetivel

@singh-lovepreet1 singh-lovepreet1 Awaiting requested review from singh-lovepreet1 singh-lovepreet1 is a code owner

Assignees

@ABHISHEK-SINHA10 ABHISHEK-SINHA10

@ShivamSh3 ShivamSh3

@singh-lovepreet1 singh-lovepreet1

Labels
validation/completed Validation is completed
Projects
None yet
Milestone
v9.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ShivamSh3 @ansible-collections-svc @rajshekarp87 @sachin-apa @ABHISHEK-SINHA10 @singh-lovepreet1 @reetivel