Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[idrac_firmware_info] - Enhancement to support iDRAC10 #742

Closed
wants to merge 10 commits into from
Closed

[idrac_firmware_info] - Enhancement to support iDRAC10 #742

wants to merge 10 commits into from

Conversation

Saksham-Nautiyal
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@Saksham-Nautiyal Saksham-Nautiyal changed the title Feature/idrac_firmware_info [idrac_firmware_info] - Enhancement to support iDRAC10 Oct 7, 2024
@Saksham-Nautiyal Saksham-Nautiyal self-assigned this Oct 7, 2024
@Saksham-Nautiyal Saksham-Nautiyal added the validation/in-progress Validation is in progress label Oct 7, 2024
@Saksham-Nautiyal Saksham-Nautiyal added this to the v9.8.0 milestone Oct 7, 2024
sachin-apa
sachin-apa reviewed Oct 16, 2024
View reviewed changes
plugins/modules/idrac_firmware_info.py
if details_response and details_response.status_code == 200 and details_response.json_data:
filtered_data = remove_key(details_response.json_data)
return filtered_data
except Exception:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we catch the specific exception here instead of generic.

@Saksham-Nautiyal
Copy link
Collaborator Author

closed as divergent branches were created. Unable to make more commits.

@Saksham-Nautiyal Saksham-Nautiyal deleted the feature/idrac_firmware_info branch October 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-apa sachin-apa sachin-apa left review comments

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 ABHISHEK-SINHA10 left review comments

@rajshekarp87 rajshekarp87 Awaiting requested review from rajshekarp87 rajshekarp87 is a code owner

@ShivamSh3 ShivamSh3 Awaiting requested review from ShivamSh3 ShivamSh3 is a code owner

@singh-lovepreet1 singh-lovepreet1 Awaiting requested review from singh-lovepreet1 singh-lovepreet1 is a code owner

Assignees

@Saksham-Nautiyal Saksham-Nautiyal

Labels
validation/in-progress Validation is in progress
Projects
None yet
Milestone
v9.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Saksham-Nautiyal @ansible-collections-svc @sachin-apa @ABHISHEK-SINHA10