-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idrac_firmware_info] - Enhancement to support iDRAC10 #742
Closed
Saksham-Nautiyal
wants to merge
10
commits into
dell:collections
from
Saksham-Nautiyal:feature/idrac_firmware_info
Closed
[idrac_firmware_info] - Enhancement to support iDRAC10 #742
Saksham-Nautiyal
wants to merge
10
commits into
dell:collections
from
Saksham-Nautiyal:feature/idrac_firmware_info
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saksham-Nautiyal
requested review from
sachin-apa,
ABHISHEK-SINHA10,
rajshekarp87,
ShivamSh3 and
singh-lovepreet1
as code owners
October 4, 2024 12:16
Can one of the admins verify this patch? |
Saksham-Nautiyal
changed the title
Feature/idrac_firmware_info
[idrac_firmware_info] - Enhancement to support iDRAC10
Oct 7, 2024
sachin-apa
reviewed
Oct 16, 2024
if details_response and details_response.status_code == 200 and details_response.json_data: | ||
filtered_data = remove_key(details_response.json_data) | ||
return filtered_data | ||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we catch the specific exception here instead of generic.
closed as divergent branches were created. Unable to make more commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
ISSUE TYPE
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION
Checklist: