-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoning E2E Test + E2E Improvements #818
Conversation
fileArg := "--from-literal=config=" + fileString | ||
err = execCommand("kubectl", "create", "secret", "generic", "-n", namespace, name, fileArg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this with special shell characters in fileString, e.g. dollar signs and exclamation marks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely exclamation marks, because one of our test secrets includes one in a field. Otherwise, no comprehensive testing was done on it, but I'm not too worried about it-- this is just running e2e tests using controlled templates and provided inputs.
b9a81fe
This reverts commit b734947.
Ignore the commit to revert, I went to click 'delete branch' and hit 'revert' instead, which opened a new branch with a revert commit. I've deleted the branch. |
Description
The primary goal of this PR is to add an E2E test scenario (and robust testing script) that covers the new zoning work. In addition to that, some improvements were added to the E2E test suite.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
E2E scenario has been run standalone. It passes, though that does not actually test zoning yet, as zoning work is not completed.