Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing file for the Operator e2e tests #672

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

OliverChen557
Copy link
Contributor

Description

The CSM Operator e2e test expects this file before running the test suite. This file was referenced here but is missing in the corresponding directory. The added file utilizes the storage_csm_powerflex.yaml file with the replication module on. The file was rename and repurposed for some reason here and it looked like this previously.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1281

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Before adding the missing file
    The test suite won't run and is stuck at the BeforeSuite stage.
    missing-file
  • After adding the missing file
    The test suite runs and pass the BeforeSuite stage.
go: upgraded github.com/onsi/ginkgo/v2 v2.20.1 => v2.20.2
/root/csm-operator/tests/e2e
  W0829 07:51:19.269142   54889 test_context.go:509] Unable to find in-cluster config, using default host : https://127.0.0.1:6443/
  Aug 29 07:51:19.269: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite: CSM Operator End-to-End Tests - /root/csm-operator/tests/e2e
===========================================================================
Random Seed: [1m1724932231[0m

Will run [1m1[0m of [1m1[0m specs
[38;5;243m------------------------------[0m
[0m[1m[BeforeSuite] [0m
[38;5;243m/root/csm-operator/tests/e2e/e2e_test.go:81[0m
  [1mSTEP:[0m Getting test environment variables [38;5;243m@ 08/29/24 07:51:19.27[0m
  [1mSTEP:[0m [powerflex] [38;5;243m@ 08/29/24 07:51:19.27[0m
  [1mSTEP:[0m Reading values file [38;5;243m@ 08/29/24 07:51:19.27[0m
  [1mSTEP:[0m Reading apex values file [38;5;243m@ 08/29/24 07:51:19.453[0m
  [1mSTEP:[0m Getting a k8s client [38;5;243m@ 08/29/24 07:51:19.562[0m
[38;5;10m[BeforeSuite] PASSED [0.296 seconds][0m

Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits have to be signed.

@OliverChen557 OliverChen557 merged commit 16afb67 into main Aug 30, 2024
7 checks passed
@OliverChen557 OliverChen557 deleted the e2e-missing-file branch August 30, 2024 20:55
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Added missing file for the Operator e2e tests

* Added new line to address yaml linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants