Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the k8s registry for health-monitor-controller. #198

Merged
merged 1 commit into from
May 19, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 commented May 19, 2023

Description

https://github.com/dell/csi-powerflex/pull/180/files#diff-9b4701bf6ee1af5c8bdc6eae5052ed420510463c7efb8c6c1e5b48612e44a642R47
The above pr missed to update the k8s registry of healthmonitor controller.
This pr address the above issue.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#744

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the csi-powerflex driver with the changes and driver got installed successfully.
  • Ran cert-csi and it passed with 100%
 Normal  Pulling    23s   kubelet            Pulling image "registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.8.0"
  Normal  Pulled     21s   kubelet            Successfully pulled image "registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.8.0" in 1.89471679s (2.127385319s including waiting)
  Normal  Created    21s   kubelet            Created container csi-external-health-monitor-controller
  Normal  Started    20s   kubelet            Started container csi-external-health-monitor-controller
master-1-LHFa5fuAy6gvi:~/csi-powerflex/dell-csi-helm-installer # kubectl get pods -n vxflexos
NAME                                   READY   STATUS    RESTARTS   AGE
vxflexos-controller-7958b8988c-pncl8   6/6     Running   0          11s
vxflexos-controller-7958b8988c-psl4l   6/6     Running   0          11s
vxflexos-node-8fqww                    2/2     Running   0          11s
vxflexos-node-sk6bf                    2/2     Running   0          11s
[2023-05-19 07:14:07]  INFO Avg time of a run:   63.03s
[2023-05-19 07:14:07]  INFO Avg time of a del:   13.33s
[2023-05-19 07:14:07]  INFO Avg time of all:     80.78s
[2023-05-19 07:14:07]  INFO During this run 100.0% of suites succeeded

@VamsiSiddu-7 VamsiSiddu-7 merged commit 5c8ba89 into main May 19, 2023
@anandrajak1 anandrajak1 deleted the fix-k8s-registry branch October 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants