Revert "refine error handling"

This reverts commit 06607e7. Signed-off-by: Shi, Crane <[email protected]>
dell · Jul 9, 2023 · fbe1e57 · fbe1e57
1 parent 6bf928d
commit fbe1e57
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/crcontrollers/storagegroup/storagegroupcontroller.go b/pkg/crcontrollers/storagegroup/storagegroupcontroller.go
@@ -103,8 +103,10 @@ func (c *Controller) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 	}
 
 	storageGroup := &sgcrd.StorageGroup{}
-	if err := c.client.ReadCR(ctx, name, "", storageGroup); err != nil && !k8serrors.IsNotFound(err) {
-		log.Errorf("error in reading %s as drive or storagegroup object: %v", name, err)
+	if err := c.client.ReadCR(ctx, name, "", storageGroup); err != nil {
+		if !k8serrors.IsNotFound(err) {
+			log.Errorf("error in reading %s as drive or storagegroup object: %v", name, err)
+		}
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}