storagegroup controller will not reconcile on drive delete event

Signed-off-by: Shi, Crane <[email protected]>

pkg/crcontrollers/storagegroup/storagegroupcontroller.go

@@ -65,13 +65,21 @@ func (c *Controller) SetupWithManager(mgr ctrl.Manager) error {
 		WithOptions(controller.Options{}).
 		Watches(&source.Kind{Type: &drivecrd.Drive{}}, &handler.EnqueueRequestForObject{}).
 		WithEventFilter(predicate.Funcs{
+			DeleteFunc: func(e event.DeleteEvent) bool {
+				return c.filterDeleteEvent(e.Object)
+			},
 			UpdateFunc: func(e event.UpdateEvent) bool {
 				return c.filterUpdateEvent(e.ObjectOld, e.ObjectNew)
 			},
 		}).
 		Complete(c)
 }
 
+func (c *Controller) filterDeleteEvent(obj runtime.Object) bool {
+	_, isStorageGroup := obj.(*sgcrd.StorageGroup)
+	return isStorageGroup
+}
+
 func (c *Controller) filterUpdateEvent(old runtime.Object, new runtime.Object) bool {
 	if newDrive, ok := new.(*drivecrd.Drive); ok {
 		if oldDrive, ok := old.(*drivecrd.Drive); ok {

pkg/crcontrollers/storagegroup/storagegroupcontroller_test.go

@@ -163,6 +163,16 @@ var (
 	}
 )
 
+func TestStorageGroupController_filterDeleteEvent(t *testing.T) {
+	kubeClient, err := k8s.GetFakeKubeClient(testNs, testLogger)
+	assert.Nil(t, err)
+
+	c := NewController(kubeClient, kubeClient, testLogger)
+
+	testDrive1 := drive1.DeepCopy()
+	assert.False(t, c.filterDeleteEvent(testDrive1))
+}
+
 func TestStorageGroupController_filterDriveUpdateEvent(t *testing.T) {
 	testDrive1 := drive1.DeepCopy()
 	testDrive2 := drive2.DeepCopy()