Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #49

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Release v2.0.0 #49

merged 5 commits into from
Mar 26, 2024

Conversation

kuttattz
Copy link
Contributor

@kuttattz kuttattz commented Mar 21, 2024

Ansible modules for Unity release version 2.0.0 includes:

Added support for Unity Puffin v5.4

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#47

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Functional Test
  • Regression Test

CHANGELOG.rst Outdated Show resolved Hide resolved
docs/Release Notes.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sachin-apa sachin-apa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please move requirements.txt from tests folder to tests/unit for unit tests to install dependency.
  2. Add a codecov.yml file for the path correction of coverage reports.

@Jennifer-John Can you please check, looks like GitHub Actions are not ran here.

@Jennifer-John
Copy link
Collaborator

  1. Please move requirements.txt from tests folder to tests/unit for unit tests to install dependency.
  2. Add a codecov.yml file for the path correction of coverage reports.

@Jennifer-John Can you please check, looks like GitHub Actions are not ran here.

Enabled the workflow , @kuttattz could you push /squash the commits, we can check the on triggered workflow

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Jennifer-John
Jennifer-John previously approved these changes Mar 22, 2024
@kuttattz kuttattz requested a review from Jennifer-John March 26, 2024 09:01
@Jennifer-John Jennifer-John merged commit df89e82 into dell:main Mar 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants