Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self closing tags? #17

Closed
Tobeyforce opened this issue Jan 11, 2022 · 10 comments
Closed

Self closing tags? #17

Tobeyforce opened this issue Jan 11, 2022 · 10 comments

Comments

@Tobeyforce
Copy link

Tobeyforce commented Jan 11, 2022

Is it possible to have the parse function return a self closing tag, meaning it's empty?
E.g {"empty": ""} or {"empty": None} right now becomes
<empty></empty> and <empty>None</empty> but I'd like to be able to receive <empty/>, a self closing tag. I realize however that selfclosing tags and empty tags might be the same thing in XML.

@delfick
Copy link
Owner

delfick commented Jan 11, 2022 via email

@Tobeyforce
Copy link
Author

Sorry I forgot to format the code in the comment so it disappeared, please have a look now :-)

@delfick
Copy link
Owner

delfick commented Jan 11, 2022 via email

delfick added a commit that referenced this issue Jan 12, 2022
@delfick
Copy link
Owner

delfick commented Jan 12, 2022

@Tobeyforce would this solve your needs ? 7ee3ae9

@delfick
Copy link
Owner

delfick commented Jan 22, 2022

@Tobeyforce ?

@Tobeyforce
Copy link
Author

@Tobeyforce ?

Let me get back to you soon, caught covid but will look at the commit as soon as I'm well :)

@delfick
Copy link
Owner

delfick commented Jan 24, 2022 via email

@amospalla
Copy link

Had the same need as Tobeyforce.

Using this commit and suddenly I've got self closing tags, which I needed for a project too.

(:

@delfick
Copy link
Owner

delfick commented Feb 15, 2022

hehehe, cool. I say I'll merge this later tonight, can always make extra changes in other PRs later if needed :)

delfick added a commit that referenced this issue Feb 16, 2022
@delfick
Copy link
Owner

delfick commented Feb 16, 2022

@amospalla @Tobeyforce ok, that commit is released in 1.7.1

Don't be afraid to ask for any other adjustments :)

@delfick delfick closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants