Improve narrowing return types #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delfick
force-pushed
the
better-return-types
branch
2 times, most recently
from
4a02ae2 to
8c5b486
Compare
Turns out that mypy plugin system doesn't give us an opportunity to change the typeguard when it relies on a Type Var. This is because we only know the value of the type var where it's called, which is the get_method/function_hook but those can only change the return type and don't have the ability to change the type guard
delfick
force-pushed
the
better-return-types
branch
from
8c5b486 to
ebe6cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this we would only resolve concrete annotations that used type variables on functions. This change makes it so that logic works for all annotations rather than only DefaultQuerySet, and also on methods.
It also adds logic to give a useful warning when a type guard is used with a concrete annotation that depends on a typevar. In that situation the mypy plugin system doesn't not provide an opportunity to resolve such an annotation where it can also modify the type guard.