PHPUnit 6 compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleugpn
pushed a commit
that referenced
this pull request
Feb 22, 2018
deleugpn
added a commit
that referenced
this pull request
Dec 17, 2020
deleugpn
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Update CallQueuedClosure to catch Throwable/Error
- Laravel Version: 8.26.1
- PHP Version: 8.0.0
### Description:
Queued closures that throw an Error will throw again when handled by CallQueuedClosure@failed, as its currently type-hinted for Exceptions only.
### Steps To Reproduce:
```php
Bus::chain([
function () {
SomeClassThatDoesntExist::throw();
}
])->dispatch();
```
The above will first throw `Error Class "SomeClassThatDoesntExist" not found`. The queue will attempt to handle it and throw again: `TypeError
Illuminate\Queue\CallQueuedClosure::failed(): Argument #1 ($e) must be of type Exception, Error given, called in /var/task/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php on line 261`
* style: styleci fixes
* Update CallQueuedClosure.php
Co-authored-by: Taylor Otwell <[email protected]>
deleugpn
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Ensure $prefix is a string Because PHP 8.1 will no longer allow it and throw: `rtrim(): Passing null to parameter #1 ($string) of type string is deprecated` * Update prefix() PHPDoc * Update Route.php Co-authored-by: Taylor Otwell <[email protected]>
deleugpn
pushed a commit
that referenced
this pull request
Aug 24, 2022
* Update Encrypter.php enforce decrypt payload to string, fix for below error `base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated in vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php on line 208` * Update Encrypter.php Co-authored-by: Taylor Otwell <[email protected]>
deleugpn
pushed a commit
that referenced
this pull request
Jul 10, 2023
…sname-hook Allow hooking the queueable collection logic
deleugpn
pushed a commit
that referenced
this pull request
Dec 30, 2023
…laravel#49474) * test: validateJson should return false when value is null Fails with Laravel Framework 10.38.2 in PHP < 8.3, introduced in laravel#49413 * fix: validateJson should return false when value is null Return false when $value is null. Avoid TypeError: json_validate(): Argument #1 ($json) must be of type string, null given, when using symfony/polyfill-php83 in PHP < 8.3. Avoid deprecation warning: json_validate(): Passing null to parameter #1 ($json) of type string is deprecated, when using PHP 8.3. --------- Co-authored-by: Rogelio Jacinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.