Prevent generating duplicate Ingress paths rules #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
force-pushed
the
fix_duplicate_ingress
branch
from
19eceb3 to
6fd0f46
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
iocanel
approved these changes
Oct 26, 2022
| @@ -15,12 +15,8 @@ | |||
| */ | |||
| package io.dekorate.kubernetes.decorator; | |||
|
|
|||
| import static io.dekorate.kubernetes.decorator.AddServiceResourceDecorator.distinct; | |||
There was a problem hiding this comment.
I think that distinct should move to a utility class.
|
Could it be that this did not make it into Quarkus If I specify the path with the property quarkus.kubernetes.ports.http.path=/mypaththen I don't get a duplicated ingress path (I'm using this as a workaround and cool new feature in the meantime 😋). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to quarkusio/quarkus#28812