Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label decorators should not be limited to ObjectMeta #609

Closed
iocanel opened this issue Sep 1, 2020 · 0 comments
Closed

Label decorators should not be limited to ObjectMeta #609

iocanel opened this issue Sep 1, 2020 · 0 comments
Assignees
@iocanel
Labels
bug Something isn't working

Comments

@iocanel
Copy link
Member

iocanel commented Sep 1, 2020

Currently our label decorators only work on ObjectMeta.
However, this is not a complete solution as labels are referenced in selectors too.
So, we should optionally control labels on those resources too.

An option would be to provide AddSelectorLabelDecorator and RemoveSelectorLabelDecorator that will act on any named resource and either delegate to specialized decorators or handle all cases internally.

An example case where this is causing issues: quarkusio/quarkus#11661
@iocanel iocanel added the bug Something isn't working label Sep 1, 2020
@iocanel iocanel self-assigned this Sep 2, 2020
iocanel added a commit to iocanel/dekorate that referenced this issue Sep 7, 2020
@iocanel
feat (dekorateio#609): Allow adding/removing labels to/from selectors
8668be7
iocanel added a commit that referenced this issue Sep 9, 2020
@iocanel
feat (#609): Allow adding/removing labels to/from selectors
14d71d0
iocanel added a commit that referenced this issue Sep 9, 2020
@iocanel
feat (#609): Allow adding/removing labels to/from selectors
f980024
@iocanel iocanel closed this as completed Sep 10, 2020
iocanel added a commit to iocanel/dekorate that referenced this issue Sep 22, 2020
@iocanel
fix (dekorateio#609): Selector decorators are now applied.
8f3f336
@iocanel iocanel mentioned this issue Sep 22, 2020
Merged
iocanel added a commit to iocanel/dekorate that referenced this issue Sep 22, 2020
@iocanel
fix (dekorateio#609): Selector decorators are now applied.
0269de7
iocanel added a commit to iocanel/dekorate that referenced this issue Sep 22, 2020
@iocanel
fix (dekorateio#609): Selector decorators are now applied.
8eafbbf
iocanel added a commit that referenced this issue Sep 22, 2020
@iocanel
fix (#609): Selector decorators are now applied.
77d6cc1
iocanel added a commit that referenced this issue Sep 22, 2020
@iocanel
fix (#609): Selector decorators are now applied.
6cd3004
aureamunoz pushed a commit to aureamunoz/dekorate that referenced this issue Dec 4, 2020
@iocanel @aureamunoz
feat (dekorateio#609): Allow adding/removing labels to/from selectors
6fb7443
aureamunoz pushed a commit to aureamunoz/dekorate that referenced this issue Dec 4, 2020
@iocanel @aureamunoz
fix (dekorateio#609): Selector decorators are now applied.
926fd0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iocanel iocanel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iocanel