Fix for crate consumers not finding Signature trait methods #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue when consuming the
bindle
crate in WAGI (and, no doubt, other applications): theed25519_dalek::Signature::from_bytes
, used ininvoice/signature.rs
andinvoice/verification.rs
, method is actually on thesignature::Signature
trait which is not in scope in those files. I don't yet understand why those files would compile in the Bindle client and server, but they don't compile in WAGI. And adding the trait to the files makes them give an "unused import" warning in Bindle!The fix is to instead use Signature's
TryFrom
implementation, which is documented in the Signature examples, doesn't need to be brought into scope, and delegates directly tofrom_bytes
so shouldn't change any behaviour #famouslastwords.@vdice would be great if you could give this a test please - I'm not sure how to exercise the signature stuff. Thanks!