This repository has been archived by the owner on May 6, 2020. It is now read-only.
fix(models/app): recreate proc types on switch from Dockerfile to buildpack #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kmala, @helgi and @bacongobbler are potential reviewers of this pull request based on my analysis of |
mboersma
force-pushed
the
fix-proctype-switch
branch
from
5c7c325
to
e2f14f0
Compare
Codecov Report@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
- Coverage 87.28% 87.24% -0.05%
==========================================
Files 44 44
Lines 3863 3872 +9
Branches 670 673 +3
==========================================
+ Hits 3372 3378 +6
- Misses 324 325 +1
- Partials 167 169 +2Continue to review full report at Codecov.
|
mboersma
force-pushed
the
fix-proctype-switch
branch
from
e2f14f0
to
efc9bbf
Compare
…ldpack Or vice versa.
mboersma
force-pushed
the
fix-proctype-switch
branch
from
efc9bbf
to
98f50c5
Compare
|
Improved and ready for review now. If you want to test this manually (not required), use example-dockerfile-python and alternate between branches with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or vice versa.
Closes deis/workflow#658.
This seems to fix things, but I need to write some unit tests to cover these cases, possibly write some e2e tests that cover this as well, and reassure myself that this doesn't create any regressions.Edit: finally got back to this PR and after some refactoring, this change fixes this edge case.