Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hafas-client and remove workaround #232

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 26 additions & 32 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ cd MMM-PublicTransportBerlin
npm ci
```

Since there is an issue with the current version of `hafas_client`, you also have to run this command to fix that:

```shell
cp base.json node_modules/hafas-client/p/bvg/base.json
```

## Update

Just enter your MMM-PublicTransportBerlin directory, pull the update and install the dependencies:
Expand Down Expand Up @@ -100,32 +94,32 @@ The module is quite configurable. These are the possible options:
Here is an example of an entry in `config.js`:

```JavaScript
{
module: "MMM-PublicTransportBerlin",
position: "top_right",
config: {
stationName: "Alexanderplatz",
stationId: "900100003",
hidden: false,
ignoredLines: ["U5", "U8", "S75", "Bus 100"],
excludedTransportationTypes: "bus,suburban,subway",
travelTimeToStation: 10,
interval: 120000,
departureMinutes: 10,
marqueeLongDirections: true,
showColoredLineSymbols: true,
useColorForRealtimeInfo: true,
showTableHeaders: true,
showTableHeadersAsSymbols: true,
maxUnreachableDepartures: 3,
maxReachableDepartures: 7,
fadeUnreachableDepartures: true,
fadeReachableDepartures: true,
fadePointForReachableDepartures: 0.25,
excludeDelayFromTimeLabel: true,
useBrightScheme: true
}
},
{
module: "MMM-PublicTransportBerlin",
position: "top_right",
config: {
stationName: "Alexanderplatz",
stationId: "900100003",
hidden: false,
ignoredLines: ["U5", "U8", "S75", "Bus 100"],
excludedTransportationTypes: "bus,suburban,subway",
travelTimeToStation: 10,
interval: 120000,
departureMinutes: 10,
marqueeLongDirections: true,
showColoredLineSymbols: true,
useColorForRealtimeInfo: true,
showTableHeaders: true,
showTableHeadersAsSymbols: true,
maxUnreachableDepartures: 3,
maxReachableDepartures: 7,
fadeUnreachableDepartures: true,
fadeReachableDepartures: true,
fadePointForReachableDepartures: 0.25,
excludeDelayFromTimeLabel: true,
useBrightScheme: true
}
},
```

## Multiple Modules
Expand Down
17 changes: 0 additions & 17 deletions base.json

This file was deleted.

19 changes: 10 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"node": ">=16"
},
"dependencies": {
"hafas-client": "^6.3.0",
"hafas-client": "^6.3.2",
"moment": "^2.30",
"vbb-line-colors": "^1.0.5",
"vbb-short-station-name": "^1.0.1"
Expand Down