Undo package-lock.json removal + minor changes #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use 'npm ci' instead of 'npm install' to avoid conflicts while running 'git pull'
MagicMirror already has them as preconditions.
Commit fecf9fd added a new feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a discussion in the forum I decided to remove the file. I didn't really like it because it doesn't correspond to best practice in the node ecosystem. The reason to remove it was because when you do
npm install, thepackage-lock.jsonis changed and the user has problems afterwards when he wants to update the module. Thepacke-lock.jsonin the repository and the local version no longer match. As I understand it, the best way to work around this is to usenpm ciinstead ofnmp install. I have now implemented this with this PR.