Add missing 'platform' field #82
Conversation
|
Resolves issue #55? |
|
So it does! Shoulda checked the issues first. |
|
Lol! Lucky you then, it looks like this PR is already approved |
|
So what's stopping this from being merged? |
|
ok I'm at a conf this week, but will be back next week, my only concert is just things looking for process.platform to be undefined or something annoying like that so I want to be in a place that i can revert if need be |
|
If they polyfilled process. I'm thinking they expect the platform property to exist. Since its part of the API of process. |
|
Hey, I don't remember anymore what I wanted this for, but if you're concerned about compatibility, just update the major version to 1.0.0 so old projects don't automatically upgrade to the change. See https://docs.npmjs.com/getting-started/semantic-versioning . |
|
this is something that isn't imported directly but is instead is pulled in
by browserify or webpack, so semvar doesn't really apply to this library
…On Mon, May 14, 2018 at 3:03 PM xloem ***@***.***> wrote:
Hey, I don't remember anymore what I wanted this for, but if you're
concerned about compatibility, just update the major version to 1.0.0 so
old projects don't automatically upgrade to the change. See
https://docs.npmjs.com/getting-started/semantic-versioning .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABE4n6v4WQfQY4XBysTe_wM-eDYiotZuks5tyZzGgaJpZM4RdZoC>
.
|
|
@calvinmetcalf Can we get this merged? Also semver can still be used for |
|
@CMCDragonkai most people don't use the library that way is the issue |
|
What evidence do you have that adding a platform variable will adversely affect existing users?
…On 31 May 2018 22:42:35 GMT+10:00, Calvin Metcalf ***@***.***> wrote:
@CMCDragonkai **most** people don't use the library that way is the
issue
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#82 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
@calvinmetcalf isn't the version of this pkg locked to this major version (at least for webpack users) here: https://github.com/webpack/node-libs-browser/blob/master/package.json Don't know about browserify, parcel, etc. |
|
@CMCDragonkai I may be off base, but I think the possibility that a bit of logic expects |
|
I was asking for evidence of libraries and applications that do that. And compare it to those that do not. And we can see what it costs to ask them to change. |
|
yeah my worry is there could be either if (!process.platform) or what @zenflow said so I don't want to accidentally break a bunch of peoples code, I also don't really want to do a major version bump just because of how this library is used, a major version bump would basically end up being a fork with some people on the old version and some people on the new one |
No description provided.