Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vite #185

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Bump vite #185

merged 1 commit into from
Dec 3, 2024

Conversation

jsandfordhughescoop
Copy link
Contributor

This bumps Vite to v6

@jsandfordhughescoop
Copy link
Contributor Author

@fabio-ivona - I believe this should be a quick merge as Vite v6 does not have any breaking changes.

@fabio-ivona fabio-ivona merged commit bbffa04 into defstudio:main Dec 3, 2024
0 of 3 checks passed
@fabio-ivona
Copy link
Member

thanks!

@jsandfordhughescoop jsandfordhughescoop deleted the vite-v6 branch December 3, 2024 09:14
"vitest": "^2.0.1"
},
"peerDependencies": {
"vite": "^5.0.0"
"vite": "^6.0.2"
Copy link

@Jas-n Jas-n Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest allowing both Vite versions to be kept?

In a minor version bump it causes a dependency error, which may not always be a quick fix.

👍

"vite": "^5.0.0 || ^6.0.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants