Skip to content

Commit

Permalink
chore: add architecture to save logs suffix on tag-and-release (#92)
Browse files Browse the repository at this point in the history
## Description

Adds matrix.architecture to the save logs suffix so that files from
different workflow runs won't conflict. See
https://github.com/defenseunicorns/uds-package-sonarqube/actions/runs/9599733342/job/26474249666
for an example of the error when they collide.

This was introduced with adding the architecture to the workflow matrix
and not adding it the the save logs step.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-sonarqube/blob/main/CONTRIBUTING.md#developer-workflow)
followed
  • Loading branch information
ericwyles authored Jun 20, 2024
1 parent 1d93a3f commit 5fbe70c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tag-and-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
ghToken: ${{ secrets.GITHUB_TOKEN }}

- name: Publish Package
run: UDS_ARCHITECTURE=${{ matrix.architecture }} uds run -f tasks/publish.yaml package --set FLAVOR=${{ matrix.flavor }}
run: uds run -f tasks/publish.yaml package --set FLAVOR=${{ matrix.flavor }}

- name: Debug Output
if: ${{ always() }}
Expand All @@ -57,4 +57,4 @@ jobs:
if: always()
uses: defenseunicorns/uds-common/.github/actions/save-logs@61450a210fd16cf14157ee417f9682a4664c05e5 # v0.6.0
with:
suffix: ${{ matrix.flavor }}-${{ github.run_id }}-${{ github.run_attempt }}
suffix: ${{ matrix.flavor }}-${{ matrix.architecture }}-${{ github.run_id }}-${{ github.run_attempt }}

0 comments on commit 5fbe70c

Please sign in to comment.