feat: expose timeouts #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahpb
previously approved these changes
Dec 3, 2024
mjnagel
reviewed
Dec 3, 2024
mjnagel
approved these changes
Dec 3, 2024
5 tasks
UnicornChance
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Dec 4, 2024
## Description Adding client session max lifespan and client access token lifespan attributes to operator for configuring keycloak clients. Identity config was [recently updated](defenseunicorns/uds-identity-config#271) to include environment variables for these realm settings, but also exposing them at the client level via the operator was necessary. ## Related Issue Relates to #676 & #188 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed --------- Co-authored-by: Micah Nagel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A request was made so that we can expose the keycloak timeouts to be overridden for demo purposes. Update exposes access token lifespan and sso session idle timeout. To be clear, these values still maintain the same defaults and uds-core will not be updating the values we use out of the box in our bundles.
Add the exposed environment variables in the example customization doc as well.
Type of change
Checklist before merging