Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keycloak upgrade wait #1037

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix: keycloak upgrade wait #1037

merged 4 commits into from
Nov 22, 2024

Conversation

UnicornChance
Copy link
Contributor

@UnicornChance UnicornChance commented Nov 21, 2024

Description

keycloak upgrades on major versions seem to be a bit finicky. Adding a wait to kubectl scale down so that the scale down finishes, before the update happens.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@UnicornChance UnicornChance self-assigned this Nov 21, 2024
@UnicornChance UnicornChance requested a review from a team as a code owner November 21, 2024 22:35
@UnicornChance UnicornChance changed the title Keycloak upgrade test fix: keycloak upgrade wait Nov 21, 2024
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally with an upgrade from 0.30.0, this behaved as anticipated.

@mjnagel mjnagel merged commit 1207812 into main Nov 22, 2024
18 checks passed
@mjnagel mjnagel deleted the keycloak-upgrade-test branch November 22, 2024 15:29
mjnagel pushed a commit that referenced this pull request Nov 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.32.0](v0.31.2...v0.32.0)
(2024-11-22)


### Features

* add ability to add custom netpols for prometheus-stack package
([#997](#997))
([472f9c5](472f9c5))
* add checkpoint uds-core slim package
([#818](#818))
([d95f6be](d95f6be))
* allow additional network rules for grafana and neuvector
([#1038](#1038))
([5c84007](5c84007))


### Bug Fixes

* keycloak upgrade wait
([#1037](#1037))
([1207812](1207812))


### Miscellaneous

* add variables for pepr memory requests in dev/demo bundles
([#1021](#1021))
([867501c](867501c))
* architecture diagrams
([#1024](#1024))
([d0bca43](d0bca43))
* **deps:** update grafana helm chart
([#998](#998))
([25d4c29](25d4c29))
* **deps:** update grafana to v11.3.1
([#1023](#1023))
([8d3cf3a](8d3cf3a))
* **deps:** update husky to v9.1.7
([#1014](#1014))
([0d9a854](0d9a854))
* **deps:** update kfc for jest to v3.3.3
([#1015](#1015))
([eba189e](eba189e))
* **deps:** update neuvector to 5.4.0
([#778](#778))
([ccd0a32](ccd0a32))
* **deps:** update pepr to v0.40.1
([#1025](#1025))
([871bdad](871bdad))
* **deps:** update support-deps
([#1006](#1006))
([bfb66a4](bfb66a4))
* **deps:** update support-deps
([#1019](#1019))
([82dfb32](82dfb32))
* **deps:** update velero helm chart to v8
([#999](#999))
([e8187be](e8187be))
* fix duplicative checkpoint publish location
([#1020](#1020))
([b497fc5](b497fc5))
* update diagrams
([#1035](#1035))
([cca5e2c](cca5e2c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants