Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set prometheus cont type #1501

Merged
merged 6 commits into from
Dec 3, 2024
Merged

feat: set prometheus cont type #1501

merged 6 commits into from
Dec 3, 2024

Conversation

btlghrants
Copy link
Collaborator

Description

Specifies content-type header on outgoing /metrics endpoint responses.

Related Issue

Fixes #1500

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Dec 3, 2024
@btlghrants btlghrants added this to the v0.41.0 milestone Dec 3, 2024
@btlghrants btlghrants changed the title Set prometheus cont type feat: set prometheus cont type Dec 3, 2024
@btlghrants btlghrants marked this pull request as ready for review December 3, 2024 19:10
@btlghrants btlghrants requested a review from a team as a code owner December 3, 2024 19:10
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.12%. Comparing base (afdc893) to head (fb47886).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/controller/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
- Coverage   79.17%   79.12%   -0.05%     
==========================================
  Files          39       39              
  Lines        1719     1720       +1     
  Branches      412      404       -8     
==========================================
  Hits         1361     1361              
- Misses        329      330       +1     
  Partials       29       29              
Files with missing lines Coverage Δ
src/lib/controller/index.ts 10.74% <0.00%> (-0.09%) ⬇️

Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will work with Prom 3.0

@cmwylie19 cmwylie19 removed this pull request from the merge queue due to a manual request Dec 3, 2024
@cmwylie19 cmwylie19 merged commit a55e8ca into main Dec 3, 2024
45 of 46 checks passed
@cmwylie19 cmwylie19 deleted the set_prometheus_cont_type branch December 3, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Pepr Metrics are being shipped with content-type text/html - prom 3 does not support
2 participants