-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add typing support to regex-related adjudicators #1484
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 257c4b8.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 78.82% 78.33% -0.50%
==========================================
Files 41 41
Lines 1804 1883 +79
Branches 403 436 +33
==========================================
+ Hits 1422 1475 +53
+ Misses 380 376 -4
- Partials 2 32 +30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change to the Pepr API that is in production and being used in delivery.
Description
This PR adds typing support for regex-related adjudicators. Merge this in after #1402.
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Relates to #1397, #1402
Type of change
Checklist before merging