We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to add more finalizer support and protect "owned" resources so they don't get deleted unless the owning object is deleted.
const { name, uid } = instance.metadata!; return [ { apiVersion: instance.apiVersion!, kind: instance.kind!, uid: uid!, name: name!, controller: true, // add blockOwnerDeletion: true, // add }, ]; }
Kubernetes Docs around ownerRefs
WebApp
(optional) A clear and concise description of any alternative solutions or features you've considered.
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
0813e9a
chore: support optional fields in ownerReferences (defenseunicorns#1104)
f8f394e
## Description This PR adds support for optional fields defined in [ownerReferences](https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/object-meta/#System). It also changes the test block to use a parameterized test. End to End Test: N/A ## Related Issue Fixes defenseunicorns#1060 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
samayer12
Successfully merging a pull request may close this issue.
Is your feature request related to a problem? Please describe.
Need to add more finalizer support and protect "owned" resources so they don't get deleted unless the owning object is deleted.
Kubernetes Docs around ownerRefs
Describe the solution you'd like
WebApp
Describe alternatives you've considered
(optional) A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: