Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): fix indexing files with api key auth #852

Merged
merged 12 commits into from
Aug 1, 2024
Merged

fix(api): fix indexing files with api key auth #852

merged 12 commits into from
Aug 1, 2024

Conversation

gphorvath
Copy link

No description provided.

@gphorvath gphorvath linked an issue Jul 29, 2024 that may be closed by this pull request
bug(api): cannot index files to vector store with api key auth #851
Closed
@gphorvath gphorvath self-assigned this Jul 29, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 29, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit a0fde4a
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66abcf8f6300e200080c0fc4

@gphorvath gphorvath added the possible-bug 🐛 Something may not be working label Jul 29, 2024
@gphorvath gphorvath marked this pull request as ready for review July 31, 2024 16:10
@gphorvath gphorvath requested a review from a team as a code owner July 31, 2024 16:10
@justinthelaw
Copy link
Contributor

Are the llama-cpp-python changes in this PR part of getting the file indexing to work locally?

justinthelaw
justinthelaw previously approved these changes Jul 31, 2024
View reviewed changes
YrrepNoj
YrrepNoj requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small requests/changes.

packages/llama-cpp-python/Makefile Outdated Show resolved Hide resolved
src/leapfrogai_api/backend/rag/leapfrogai_embeddings.py Outdated Show resolved Hide resolved
@YrrepNoj YrrepNoj dismissed stale reviews from justinthelaw and CollectiveUnicorn via 40711c6 August 1, 2024 18:04
@YrrepNoj YrrepNoj force-pushed the 851-bugapi-cannot-index-files-to-vector-store-with-api-key-auth branch from 40711c6 to 5b1eed3 Compare August 1, 2024 18:08
@gphorvath gphorvath merged commit c4d9c3f into main Aug 1, 2024
20 checks passed
@gphorvath gphorvath deleted the 851-bugapi-cannot-index-files-to-vector-store-with-api-key-auth branch August 1, 2024 23:45
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinthelaw justinthelaw justinthelaw approved these changes

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@CollectiveUnicorn CollectiveUnicorn CollectiveUnicorn left review comments

Assignees

@gphorvath gphorvath

Labels
possible-bug 🐛 Something may not be working
Projects
None yet
Milestone
Current - RAG UX Enhancements | Model...
Development

Successfully merging this pull request may close these issues.

bug(api): cannot index files to vector store with api key auth
4 participants
@gphorvath @justinthelaw @YrrepNoj @CollectiveUnicorn