Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI Playwright Tests to E2E Workflow #551

Merged
merged 34 commits into from
Jul 18, 2024
Merged

Add UI Playwright Tests to E2E Workflow #551

merged 34 commits into from
Jul 18, 2024

Conversation

jalling97
Copy link
Contributor

@jalling97 jalling97 commented May 21, 2024 •
edited
Loading

  • Adds the UI Zarf Package deployment to the e2e workflow
  • Calls some of the UI Playwright tests, utilizing the deployed instances of the UI, API, and Supabase

@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 35ca3d5
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66991e5b7842260008ed90e6

@jalling97 jalling97 marked this pull request as ready for review May 21, 2024 16:08
@jalling97 jalling97 requested a review from a team as a code owner May 21, 2024 16:08
@jalling97 jalling97 self-assigned this May 21, 2024
@jalling97 jalling97 linked an issue May 23, 2024 that may be closed by this pull request
Add Playwright UI tests to E2E workflow #557
Closed
@jalling97 jalling97 marked this pull request as draft June 6, 2024 15:05
@andrewrisse andrewrisse mentioned this pull request Jul 9, 2024
Merged
@andrewrisse
Copy link
Contributor

When we re-address this story, once tests all pass in one browser, attempt to enable other browsers as well. Try running in parallel and concurrently to see how performant they are.

@alekst23 alekst23 added this to the EVERGREEN milestone Jul 11, 2024
@jalling97 jalling97 marked this pull request as ready for review July 11, 2024 21:08
@jalling97
Copy link
Contributor Author

Not quite ready for review; I need to test the e2e workflow a few times.

andrewrisse
andrewrisse reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@andrewrisse andrewrisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests running and passing on my machine still!

.github/workflows/e2e.yaml Show resolved Hide resolved
.github/workflows/e2e.yaml Show resolved Hide resolved
.github/workflows/e2e.yaml Show resolved Hide resolved
src/leapfrogai_ui/playwright.config.ts Outdated Show resolved Hide resolved
src/leapfrogai_ui/playwright.config.ts Outdated Show resolved Hide resolved
@jalling97 jalling97 merged commit 7c1af64 into main Jul 18, 2024
14 checks passed
@jalling97 jalling97 deleted the add-playwright-tests-to-e2e-workflow branch July 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinthelaw justinthelaw justinthelaw approved these changes

@andrewrisse andrewrisse andrewrisse approved these changes

Assignees

@jalling97 jalling97

Labels
None yet
Projects
None yet
Milestone
EVERGREEN
Development

Successfully merging this pull request may close these issues.

Add Playwright UI tests to E2E workflow
4 participants
@jalling97 @andrewrisse @justinthelaw @alekst23