add parameters to example modules and update readmes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack-is-cool
requested review from
jeff-mccoy,
brianrexrode,
ntwkninja,
RothAndrew and
UncleGedd
as code owners
ntwkninja
reviewed
Feb 28, 2023
There was a problem hiding this comment.
The aws admin / arn locals is a great addition. Overall, looks great.
@JaseKoonce Would you mind running through both the managed and self-managed node group readme's?
On a separate note, there is a lot of overlap between the two examples (read, duplication). @zack-is-cool what are your thoughts on creating a top level example in the future so we aren't having to duplicate docs and maintain those?
Signed-off-by: jase koonce <[email protected]>
wirewc
approved these changes
Mar 1, 2023
|
@ntwkninja want to give this a quick look? @zack-is-cool finished fixing the verified signature stuff (well done!). |
JaseKoonce
added a commit
that referenced
this pull request
Mar 7, 2023
* make optional * update readme * update env vars * unable to iterate over tuple if it doesn't exist * default null * parameterize instance type * refactor * add * parameterize instance type * parameterize instance type * update readme * parameterize * add parameters to example * add backend.tf.example * update lockfile thing * add backend.tf.example * DRYify admin username parameters * update variables * DRYify input vars * add -foce-copy * Remove variable, do not need defaults at the moment * added cluster_name * update readmes * updating self-managed/managed readmes Signed-off-by: jase koonce <[email protected]> * fix some pah and var logic * update readme * ignore build dir * update readme * Empty commit * testing sign * testing sign again * testing sign again again * update readme * update env vars * unable to iterate over tuple if it doesn't exist * default null * parameterize instance type * refactor * add * parameterize instance type * parameterize instance type * update readme * Move the tfstate-backend module to its own repo (#77) * Update README.md (#78) * Use new remote tfstate-backend module (and delete the one in this repo) (#80) * eks output fix (#83) * parameterize * add parameters to example * add backend.tf.example * update lockfile thing * add backend.tf.example * DRYify admin username parameters * update variables * DRYify input vars * add -foce-copy * Remove variable, do not need defaults at the moment * added cluster_name * update readmes * fix some pah and var logic * update readme * update readme * updating self-managed/managed readmes Signed-off-by: jase koonce <[email protected]> * Empty commit * testing sign * testing sign again * testing sign again again --------- Signed-off-by: jase koonce <[email protected]> Co-authored-by: jase koonce <[email protected]> Co-authored-by: Andy Roth <[email protected]> Co-authored-by: Gabe <[email protected]>
ntwkninja
added a commit
that referenced
this pull request
Mar 9, 2023
* added and tested managed node group Signed-off-by: jase koonce <[email protected]> * rebasing Signed-off-by: jase koonce <[email protected]> * pre-commit Signed-off-by: jase koonce <[email protected]> * bastion logging wip Signed-off-by: jase koonce <[email protected]> * adding eventbridge rules to aggregate logs Signed-off-by: jase koonce <[email protected]> * tested/adjusted formating Signed-off-by: jase koonce <[email protected]> * rebase Signed-off-by: jase koonce <[email protected]> * WIP Signed-off-by: jase koonce <[email protected]> * adds username logging/one concurrent session Signed-off-by: jase koonce <[email protected]> * cleanup/precommit Signed-off-by: jase koonce <[email protected]> * add parameters to example modules and update readmes (#84) * make optional * update readme * update env vars * unable to iterate over tuple if it doesn't exist * default null * parameterize instance type * refactor * add * parameterize instance type * parameterize instance type * update readme * parameterize * add parameters to example * add backend.tf.example * update lockfile thing * add backend.tf.example * DRYify admin username parameters * update variables * DRYify input vars * add -foce-copy * Remove variable, do not need defaults at the moment * added cluster_name * update readmes * updating self-managed/managed readmes Signed-off-by: jase koonce <[email protected]> * fix some pah and var logic * update readme * ignore build dir * update readme * Empty commit * testing sign * testing sign again * testing sign again again * update readme * update env vars * unable to iterate over tuple if it doesn't exist * default null * parameterize instance type * refactor * add * parameterize instance type * parameterize instance type * update readme * Move the tfstate-backend module to its own repo (#77) * Update README.md (#78) * Use new remote tfstate-backend module (and delete the one in this repo) (#80) * eks output fix (#83) * parameterize * add parameters to example * add backend.tf.example * update lockfile thing * add backend.tf.example * DRYify admin username parameters * update variables * DRYify input vars * add -foce-copy * Remove variable, do not need defaults at the moment * added cluster_name * update readmes * fix some pah and var logic * update readme * update readme * updating self-managed/managed readmes Signed-off-by: jase koonce <[email protected]> * Empty commit * testing sign * testing sign again * testing sign again again --------- Signed-off-by: jase koonce <[email protected]> Co-authored-by: jase koonce <[email protected]> Co-authored-by: Andy Roth <[email protected]> Co-authored-by: Gabe <[email protected]> * Update CODEOWNERS to use groups (#87) * Add GitHub Actions workflows for enabling test automation (#86) * change kc db output from endpoint to address (#92) * added and tested managed node group Signed-off-by: jase koonce <[email protected]> * rebase Signed-off-by: jase koonce <[email protected]> * Fixing cloudwatch error Signed-off-by: jase koonce <[email protected]> * adjusting userdata to log out newest session Signed-off-by: jase koonce <[email protected]> * Fixing failed checks Signed-off-by: jase koonce <[email protected]> * bastion refactor Signed-off-by: jase koonce <[email protected]> * adding newline for checks Signed-off-by: jase koonce <[email protected]> * add checkov comments/adjust startup script behavior Signed-off-by: jase koonce <[email protected]> * formating adjustment Signed-off-by: jase koonce <[email protected]> --------- Signed-off-by: jase koonce <[email protected]> Co-authored-by: Gabe <[email protected]> Co-authored-by: brian.rexrode <[email protected]> Co-authored-by: Zack A <[email protected]> Co-authored-by: Andy Roth <[email protected]> Co-authored-by: brianrexrode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add parameters to example modules and update readmes