Externalize logging bucket and KMS key #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RothAndrew
changed the title
RothAndrew
changed the title
RothAndrew
changed the title
|
/test all |
|
Sure, no sweat. Anything else? |
|
nope, lgtm. I'll approve |
ntwkninja
pushed a commit
that referenced
this pull request
Apr 15, 2023
Closed
ntwkninja
added a commit
that referenced
this pull request
Apr 23, 2023
* add secondary vpc cidr * Externalize logging bucket and KMS key (#141) * Feature/calico cni (#140) * wip * wip * Delete complete-self-managed-nodegroup example since secure mode covers its intent * wip * wip * Change keycloak_enabled back to true * undo the managed stuff and change keycloak_enabled back to false * wip * Update providers to use eks module output instead of data object * Change keycloak_enabled back to true * wip * merge main * update provider things and cluster_addons var * remove unnessary complicated logic * turn addons on * weird merge caused dupes * clean comments * fix auto_scaling_group_names inputs * fix config * adding these back in * rollback all create_aws_auth_configmap logic * fix calico things * tags on tags on tags * helm things * bump * make default to save $$$ * unblock? * make true * bug :( * does this even do anything * Revert "make default to save $$$" This reverts commit c25b2d4. --------- Co-authored-by: Andy Roth <[email protected]> * add secondary vpc cidr * subnet tweak * one block in a blocks field * add netpols conf to common.tfvars, add supported elements to README, update supported EKS version * wip - vpc cni custom networking * working * thought I did this already but apparently not * update eni config * wip - networking fun * everything looks right but zarf init is unhappy * everything looks right but zarf init is unhappy * add wait for nodegroups (needed for vpc cni sutom networking) * make var descirptions match * fix pre-commit --------- Signed-off-by: Gabe <[email protected]> Co-authored-by: Andy Roth <[email protected]> Co-authored-by: Zack A <[email protected]> Co-authored-by: brian.rexrode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
Closes #152