Use only cxx14 features in clustering extension.

[marscher]

Also disable circle ci and update pybind11 to 2.4.2

fixes #31

[clonker]

Apart from the if constexpr thing looks good to me! I can make the change as well if you want

[marscher]

Thanks for the review. Please go ahead and change it accordingly Am 14. Oktober 2019 19:11:59 MESZ schrieb Moritz Hoffmann <[email protected]>:

…

clonker commented on this pull request. Apart from the if constexpr thing looks good to me! I can make the change as well if you want > - if constexpr (std::is_same_v<T, float>) { - return compute_f(xs, ys, dim); - } else { - return compute_d(xs, ys, dim); - } + return compute_d(xs, ys, dim); } + float compute(const float* xs, const float* ys, std::size_t dim) const { + return compute_f(xs, ys, dim); + } this isnt actually doing the same thing as far as i can tell, the way to work around `if constexpr` would be with `std::enable_if` -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: aeon-toolkit/aeon#32 (review)

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[clonker]

Not sure why this failed, says
##[error]Error: Failed find: EPERM: operation not permitted, scandir '/Users/vsts/Library/Application Support/AddressBook'
in the test result publishing step

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@4a064da). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   82.42%           
=========================================
  Files             ?       35           
  Lines             ?     2857           
  Branches          ?        0           
=========================================
  Hits              ?     2355           
  Misses            ?      502           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a064da...e86eb17. Read the comment docs.