This repository has been archived by the owner on Jul 8, 2023. It is now read-only.
Bugfix on with-callback-on-change for a non-update after a first update on props. #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surely you can notice the bug when you look at the code update, but i will illustrate the bug:
Component with props
{ a: 1, b: 2 }
->
setProps on Component to { a: 2, b: 2 }
->
setProps on Component to { a: 2, b: 3 }
The callback should have been called only one time (
a: 1
->a: 2
), but it is actually being called 2 times.Commit notes: