Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo notebook #68

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Demo notebook #68

merged 6 commits into from
Jun 6, 2024

Conversation

voetberg
Copy link
Contributor

@voetberg voetberg commented Jun 6, 2024

Okay so there's actually a lot in here. This is bad practice sorry.

  1. Does the demo notebook thing. Closes Demo Notebook #66 cc: @bnord
  2. Reworks some of the base classes so things can be used standalone. That was bothering me.
  3. Changes how the simulator is loaded in. Turns out jupyter nb's REALLLLLYYYYY don't like it when you modify env vars on the fly. Writes simulator paths to a hidden json now.
  4. Corrects problems with the way the merge for LC2ST was done. The revert messed some things up.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bnord bnord merged commit 3f67b67 into deepskies:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo Notebook
2 participants