Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bones #43

Merged
merged 9 commits into from
Apr 1, 2024
Merged

Bones #43

merged 9 commits into from
Apr 1, 2024

Conversation

voetberg
Copy link
Contributor

Major rewrite

  • Moves io to two different data/models modules
  • Creates a "config" module, can read a config from a path, or set it to an env var to read later
  • Creates generic plotting/metric modules to be filled in with different plots/metrics
  • Makes a "client" module (currently empty) to handle cli based pipelining.
  • Removed extra leftovers form showyourwork, not needed for a dev project.

@voetberg voetberg requested a review from bnord March 21, 2024 15:59
@@ -16,7 +16,7 @@ def _load(self, path:str) -> None:
posterior = pickle.load(file)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beckynevin is the posterior the only object we'll do any diagnostics on? If we wanted to expand to include the likelihood (e.g., SNLE) in a beta version, do you know if that would require significant structural changes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would using the likelihood require? Would it require running the MCMC chain to get to the posterior? Or are you talking about evaluating the likelihood itself? Both would require significant structural changes; the former would require the package to handle MCMCing while the later I think would require redesigning the metrics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if people wanted to stop at the Likelihood and not go to the Posterior.

I don't think we've talked about metrics/diagnostics for that, but I wasn't sure if you had any schemes going in that direction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not advocating for adding more tools to get a posterior from the likelihood.

@voetberg voetberg linked an issue Mar 29, 2024 that may be closed by this pull request
@voetberg voetberg merged commit 87a2e42 into deepskies:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulator Methods
3 participants