Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding SentenceSplitter to init imports #8644

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: adding SentenceSplitter to init imports #8644

merged 1 commit into from
Dec 16, 2024
+2 −1

Conversation

davidsbatista
Copy link
Contributor

Proposed Changes:

  • Adding SentenceSpitter to haystack.preprocessores.init

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@davidsbatista davidsbatista requested a review from a team as a code owner December 16, 2024 09:51
@davidsbatista davidsbatista requested review from mpangrazzi and removed request for a team December 16, 2024 09:51
@davidsbatista davidsbatista changed the title adding SentenceSplitter to init imports fix: adding SentenceSplitter to init imports Dec 16, 2024
@davidsbatista davidsbatista changed the title fix: adding SentenceSplitter to init imports fix: adding SentenceSplitter to init imports Dec 16, 2024
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 16, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12350068709

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 90.48%
Totals Coverage Status
Change from base Build 12314927856: 0.001%
Covered Lines: 8107
Relevant Lines: 8960
💛 - Coveralls

@davidsbatista davidsbatista merged commit a5b57f4 into main Dec 16, 2024
17 of 18 checks passed
@davidsbatista davidsbatista deleted the adding-SentenceSplitter-init-imports branch December 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpangrazzi mpangrazzi mpangrazzi approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @coveralls @mpangrazzi