Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin openai>=1.56.1 #8632

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore: pin openai>=1.56.1 #8632

merged 2 commits into from
Dec 12, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • pin to openai>=1.56.1 to make sure that Haystack works and, when installed in Colab, updates the OpenAI client.

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 marked this pull request as ready for review December 12, 2024 15:11
@anakin87 anakin87 requested review from a team as code owners December 12, 2024 15:11
@anakin87 anakin87 requested review from dfokina, davidsbatista and bilgeyucel and removed request for a team December 12, 2024 15:11
@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12299237618

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.479%

Totals Coverage Status
Change from base Build 12298346120: 0.0%
Covered Lines: 8106
Relevant Lines: 8959

💛 - Coveralls

@anakin87 anakin87 merged commit 2a9a640 into main Dec 12, 2024
31 checks passed
@anakin87 anakin87 deleted the pin-openai-httpx-bug branch December 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants