Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add deprecation warning nltk document splitter #8628

Merged
merged 6 commits into from
Dec 12, 2024
Merged

docs: add deprecation warning nltk document splitter #8628

merged 6 commits into from
Dec 12, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Dec 11, 2024 •
edited by anakin87
Loading

Related Issues

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@davidsbatista davidsbatista mentioned this pull request Dec 11, 2024
Merged
@davidsbatista davidsbatista marked this pull request as ready for review December 11, 2024 18:12
@davidsbatista davidsbatista requested review from a team as code owners December 11, 2024 18:12
@davidsbatista davidsbatista requested review from dfokina and vblagoje and removed request for a team December 11, 2024 18:12
@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12294809031

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 90.336%
Files with Coverage Reduction New Missed Lines %
components/preprocessors/nltk_document_splitter.py 3 97.39%
Totals Coverage Status
Change from base Build 12292536037: 0.003%
Covered Lines: 8020
Relevant Lines: 8878
💛 - Coveralls

anakin87
anakin87 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also create an issue for the removal of this component and add the issue to the 2.10.0 milestone.

@davidsbatista davidsbatista merged commit 6cceaac into main Dec 12, 2024
18 checks passed
@davidsbatista davidsbatista deleted the add-deprecation-warning-NLTKDocumentSplitter branch December 12, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

@dfokina dfokina Awaiting requested review from dfokina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidsbatista @coveralls @anakin87 @dfokina