chore: fixing pylint issues

[davidsbatista]

Proposed Changes:

I'm fixing the issue with pylint, which locally runs over all files. Since the last update (I suppose to pylint), it makes the local linting process raise an issue for functions with more than 5 positional arguments, which we have a lot of.

We should probably increase this number to slightly more than 5 in pyproject.toml, e.g.: max-positional-arguments = 10 and then iteratively remove this disablement as we refactor some of the functions.

How did you test it?

I successfully ran pylint on main branch in my local environment without pylint raising any issues.

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 12240140835

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 8 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.001%) to 90.335%

---

Files with Coverage Reduction	New Missed Lines	%
components/readers/extractive.py	8	95.71%

Totals
Change from base Build 12238133563:	0.001%
Covered Lines:	8038
Relevant Lines:	8898

---

💛 - Coveralls

[davidsbatista]

adding @anakin87 as well

[anakin87]

Thanks for taking care of this.
Looks good in general, but I left some suggestions.

In the long term, I would prefer to keep the current (default) value of max-positional-arguments, so that when adding new code, we are aware of this and behave correctly.

[mpangrazzi]

@davidsbatista @anakin87

We should probably increase this number to slightly more than 5 in pyproject.toml, e.g.: max-positional-arguments = 10 and then iteratively remove this disablement as we refactor some of the functions.

I actually agree on this, maybe we can do it on another PR? WDYT @anakin87? Edit: saw that you don't want to do it.

Other changes LGTM!

[davidsbatista]

@mpangrazzi we can do discuss how to do it or do it in another PR.

For now I just wanted to fix this so that I pylint doesn't raise any issues when running it locally.

[davidsbatista]

@anakin87 trying to the fix the _postprocess() and _preprocess() from the ExtractiveReader - adding a kwargs * doesn't seem to work as for the others - investigating...

[davidsbatista]

************* Module haystack.components.readers.extractive
haystack/components/readers/extractive.py:603:86: E1121: Too many positional arguments for method call (too-many-function-args)
haystack/components/readers/extractive.py:603:86: E1125: Missing mandatory keyword argument 'queries' in method call (missing-kwoa)
haystack/components/readers/extractive.py:603:86: E1125: Missing mandatory keyword argument 'documents' in method call (missing-kwoa)
haystack/components/readers/extractive.py:603:86: E1125: Missing mandatory keyword argument 'max_seq_length' in method call (missing-kwoa)
haystack/components/readers/extractive.py:603:86: E1125: Missing mandatory keyword argument 'query_ids' in method call (missing-kwoa)
haystack/components/readers/extractive.py:603:86: E1125: Missing mandatory keyword argument 'stride' in method call (missing-kwoa)
haystack/components/readers/extractive.py:632:36: E1121: Too many positional arguments for method call (too-many-function-args)
haystack/components/readers/extractive.py:632:36: E1125: Missing mandatory keyword argument 'start' in method call (missing-kwoa)
haystack/components/readers/extractive.py:632:36: E1125: Missing mandatory keyword argument 'end' in method call (missing-kwoa)
haystack/components/readers/extractive.py:632:36: E1125: Missing mandatory keyword argument 'sequence_ids' in method call (missing-kwoa)
haystack/components/readers/extractive.py:632:36: E1125: Missing mandatory keyword argument 'attention_mask' in method call (missing-kwoa)
haystack/components/readers/extractive.py:632:36: E1125: Missing mandatory keyword argument 'answers_per_seq' in method call (missing-kwoa)
haystack/components/readers/extractive.py:632:36: E1125: Missing mandatory keyword argument 'encodings' in method call (missing-kwoa)

[anakin87]

@davidsbatista I pushed a commit (c389a57) to show what I mean: once you modify the method, you should also modify the caller and related tests.

[davidsbatista]

ok, I see, thanks 👍🏽

[anakin87]

🙏