-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RecursiveSplitter
component for Document
preprocessing
#8605
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12357154921Details
💛 - Coveralls |
@bglearning - mentioning you since I believe you were the one with most interest in this feature |
Co-authored-by: Sebastian Husch Lee <[email protected]>
Hey @davidsbatista just pinging to make sure you saw this. |
I saw it as well, no worries - I need to still to make the edge cases work and add the new feature and then look into this - the changes and needed features started to pile up, I need more time - but I did not forgot no worries |
So, I agree and we should definitely do it. But, out of the scope of this PR/issue - we should finalise this one first, merge it and then see how to extract common functionalities from both to an external utils file/module. |
Okay sounds good let's do that. Could you open an issue to track this? |
Issue open: #8645 |
RecursiveSplitter
component for Document
preprocessing
Related Issues
Proposed Changes:
How did you test it?
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.