Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add job to check imports #8594

Merged
merged 13 commits into from
Nov 29, 2024
Merged

ci: add job to check imports #8594

merged 13 commits into from
Nov 29, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 28, 2024

Related Issues

Proposed Changes:

  • add a new check-imports job to the tests workflow: running from hatch default environment (with only basic Haystack dependencies), it tries to import each package

    • if everything is OK, the test passes and prints the number of imported packages
    • if there are errors, it fails and shows the stacktrace of each error encountered
  • remove test_imports.py test and its dependencies: it was introduced in test: test for missing dependencies #7278, but it never worked and I could not fix it

How did you test it?

  • I tried it in this PR: here, it found some errors (one was intentional to test the job; the other had been there for a while :-)) - I'm also fixing them in this PR

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 12085867312

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.307%

Totals Coverage Status
Change from base Build 12068906443: 0.0%
Covered Lines: 8031
Relevant Lines: 8893

💛 - Coveralls

@anakin87 anakin87 changed the title try checking imports ci: add job to check imports Nov 28, 2024
@anakin87 anakin87 marked this pull request as ready for review November 28, 2024 18:22
@anakin87 anakin87 requested review from a team as code owners November 28, 2024 18:23
@anakin87 anakin87 requested review from dfokina, mpangrazzi and shadeMe and removed request for a team November 28, 2024 18:23
.github/utils/check_imports.py Outdated Show resolved Hide resolved
@anakin87 anakin87 enabled auto-merge (squash) November 29, 2024 13:49
@anakin87 anakin87 merged commit de7099e into main Nov 29, 2024
21 checks passed
@anakin87 anakin87 deleted the test-imports branch November 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a workflow to test imports
3 participants