Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert change to deserialization error in Pipeline #8591

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: Revert change to deserialization error in Pipeline #8591

merged 1 commit into from
Nov 28, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Nov 28, 2024

Proposed Changes:

Revert previous change committed directly to main

Checklist

@shadeMe shadeMe requested a review from julian-risch November 28, 2024 11:25
@shadeMe shadeMe requested a review from a team as a code owner November 28, 2024 11:25
@shadeMe shadeMe requested review from Amnah199 and removed request for a team November 28, 2024 11:25
@shadeMe shadeMe added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 28, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12067960433

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 90.307%
Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 31 88.66%
Totals Coverage Status
Change from base Build 12066860315: 0.0%
Covered Lines: 8031
Relevant Lines: 8893
💛 - Coveralls

@shadeMe shadeMe merged commit 163c06f into deepset-ai:main Nov 28, 2024
16 of 17 checks passed
@shadeMe shadeMe deleted the chore/revert-serde-error-commit branch November 28, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadeMe @coveralls @julian-risch