refactor: ChatMessage - introduce text property and deprecate content
#8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
type:documentation
Pull Request Test Coverage Report for Build 12066314014Details
💛 - Coveralls |
anakin87
requested review from
dfokina and
silvanocerza
and removed request for
a team
mpangrazzi
approved these changes
Nov 28, 2024
Amnah199
pushed a commit
that referenced
this pull request
Dec 3, 2024
…ntent` (#8588) * introduce text property and deprecate content * release note * minor test refactoring --------- Co-authored-by: Michele Pangrazzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
ChatMessage- introducetextproperty #8587 (see Migration of experimentalChatMessageto Haystack #8583 for the motivation)Proposed Changes:
textproperty that mirrorscontentcontentattribute, show a deprecation warning telling thatcontentwill be removed in 2.9.0 and to usetextinsteadHow did you test it?
CI, new tests
Notes for the reviewer
Adaptation of all Haystack components to use
textinstead ofcontentwill be done in a future PR.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.