Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use class methods to create ChatMessage #8581

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 26, 2024

Related Issues

Proposed Changes:

  • wherever possible, replace usage of dataclass constructor with the appropriate class method

How did you test it?

CI

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12028566042

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.3%

Totals Coverage Status
Change from base Build 12027959745: 0.0%
Covered Lines: 7987
Relevant Lines: 8845

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review November 26, 2024 10:24
@anakin87 anakin87 requested review from a team as code owners November 26, 2024 10:24
@anakin87 anakin87 requested review from dfokina and mpangrazzi and removed request for a team November 26, 2024 10:24
@anakin87 anakin87 added this to the 2.8.0 milestone Nov 27, 2024
@anakin87 anakin87 enabled auto-merge (squash) November 28, 2024 09:23
@anakin87 anakin87 merged commit 51c1390 into main Nov 28, 2024
18 checks passed
@anakin87 anakin87 deleted the chatmessage-use-class-methods branch November 28, 2024 09:35
Amnah199 pushed a commit that referenced this pull request Dec 3, 2024
* use class methods to build messages

* fix failing format
Amnah199 pushed a commit that referenced this pull request Dec 3, 2024
* use class methods to build messages

* fix failing format
Amnah199 pushed a commit that referenced this pull request Dec 3, 2024
* use class methods to build messages

* fix failing format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants