Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix linting of MetaFieldGroupingRanker #8570

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: fix linting of MetaFieldGroupingRanker #8570

merged 1 commit into from
Nov 22, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Simplify the code to make the linter happy

How did you test it?

CI

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 22, 2024
@anakin87 anakin87 requested a review from vblagoje November 22, 2024 12:25
@anakin87 anakin87 marked this pull request as ready for review November 22, 2024 12:26
@anakin87 anakin87 requested a review from a team as a code owner November 22, 2024 12:26
@anakin87 anakin87 requested review from silvanocerza and removed request for a team November 22, 2024 12:26
@coveralls
Copy link
Collaborator

coveralls commented Nov 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11972543392

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 90.247%
Totals Coverage Status
Change from base Build 11950296172: -0.001%
Covered Lines: 7847
Relevant Lines: 8695
💛 - Coveralls

@anakin87 anakin87 mentioned this pull request Nov 22, 2024
Merged
vblagoje
vblagoje approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@anakin87 anakin87 merged commit 0b2a299 into main Nov 22, 2024
27 of 28 checks passed
@anakin87 anakin87 deleted the fix-lint-meta-field-grouping-ranker branch November 22, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@silvanocerza silvanocerza Awaiting requested review from silvanocerza silvanocerza is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @vblagoje