Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge linting steps into the test workflow #7866

Merged
merged 5 commits into from
Jun 14, 2024
Merged

ci: merge linting steps into the test workflow #7866

merged 5 commits into from
Jun 14, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 14, 2024

Related Issues

  • speed up CI feedback cycle

Proposed Changes:

Tests and linting have the same set of dependencies. In preparation of a caching step that should speed up test execution, we merge the linting steps into the test workflow, removing the dedicated workflow.

How did you test it?

CI

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner June 14, 2024 13:14
@masci masci requested review from davidsbatista and removed request for a team June 14, 2024 13:14
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9516781022

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.64%

Totals Coverage Status
Change from base Build 9516509669: 0.0%
Covered Lines: 6896
Relevant Lines: 7693

💛 - Coveralls

@masci masci merged commit 24518df into main Jun 14, 2024
5 checks passed
@masci masci deleted the massi/ci branch June 14, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants