test: Check for RuntimeError instead of ComponentError in NamedEntityExtractor test #7769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
I am not convinced there really is a need for an end-to-end test here. We're not testing the warm up of any of the other components with end-to-end tests. In my understanding it's also not a good end-to-end because it doesn't do more than initializing.
I suggest we merge this fix so that the end-to-end test runs through again. We can open a separate issue about making all the tests in the fail unit or integration tests and only keep test_ner_extractor_in_pipeline as e2e test.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.