Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Check for RuntimeError instead of ComponentError in NamedEntityExtractor test #7769

Merged
merged 1 commit into from
May 31, 2024

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented May 30, 2024

Related Issues

Proposed Changes:

  • Check for RuntimeError instead of ComponentError

How did you test it?

Notes for the reviewer

I am not convinced there really is a need for an end-to-end test here. We're not testing the warm up of any of the other components with end-to-end tests. In my understanding it's also not a good end-to-end because it doesn't do more than initializing.
I suggest we merge this fix so that the end-to-end test runs through again. We can open a separate issue about making all the tests in the fail unit or integration tests and only keep test_ner_extractor_in_pipeline as e2e test.

Checklist

@julian-risch julian-risch added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 30, 2024
@julian-risch julian-risch requested a review from a team as a code owner May 30, 2024 12:55
@julian-risch julian-risch requested review from silvanocerza and removed request for a team May 30, 2024 12:55
@masci masci merged commit 6723dc3 into main May 31, 2024
14 checks passed
@masci masci deleted the e2e-named-entity-extractor branch May 31, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamedEntityExtractor e2e test fails when component has not been warmed up
2 participants