-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add __eq__
method to SparseEmbedding
#7574
Conversation
Would it make more sense to make it a dataclass at this point? 🤔 |
@silvanocerza I don't expect many more changes and features to be added to this object. |
Pull Request Test Coverage Report for Build 8799970368Details
💛 - Coveralls |
@anakin87 not essential probably but looking at the code the behaviour is really similar to a dataclass without being one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍🏽
Related Issues
While working on hybrid retrieval, I noticed we lack a proper way to compare
SparseEmbedding
objects.Proposed Changes:
Add an
__eq__
method toSparseEmbedding
class to compare twoSparseEmbedding
objects.How did you test it?
CI, new test
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.